chat order #92
Labels
No labels
backend
bug
discord
do later
duplicate
enhancement
epic
frontend
good first issue
help wanted
need more info
question
top priority
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
daratine/gex#92
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In this map
https://gex.honu.pw/match/632c3e6914c72471a7baf645c44e0a4b
The chat at 14m 19s is out of order.
Here is the relevant chat section:
[14m 19s] (Everyone) // Gier // we are absolutely fried
[14m 19s] (Everyone) // Gier // actually not probably
[14m 19s] (Allies [Team 2]) // thatmx5 // whole team left
[14m 19s] (Everyone) // JORDNNN // you all good?
[14m 19s] (Everyone) // Gier // ngl we're probably cooked
I would have to check the replay to be sure, but I know for sure that Gier's comments are backwards. I would guess this has something to do with the order that you parse the game/chat file. After taking a look at the replay though, there was a pause at 8:10, so lots of chatting then. It seems to be mostly in reverse order, but not entirely.
Side note. The time listed in your chat and the time listed in game isn't the same. The 8m 10s chat happened at 5m 44s in game. I assume that has to do with the loading and placing time. But if you can figure a way to get them the same, it would be a nice QoL update. It looks like you could look for the game started line and use that to get the timing correct?
fixed in
77e93d7aadby also using the internal db id of the chat message. chat messages are parsed in order, so if the timestamp is the same, then the id will break the tiekeeping open to fix the timestamps being based on launch time, rather than start time